Fix dx.pl Spot::dup typo

[spider.git] / cmd / dx.pl

diff --git a/cmd/dx.pl b/cmd/dx.pl
index c18a2df372f9d7751e8df8adcc7182a611b8ab64..f1f72d4d5a7ada3eed523966fea020d4ccf5cca0 100644 (file)
--- a/cmd/dx.pl
+++ b/cmd/dx.pl
@@ -18,8 +18,10 @@ my $valid = 0;
 my $localonly;
 my $oline = $line;
 
+#$DB::single=1;
+
 return (1, $self->msg('e5')) if $self->remotecmd || $self->inscript;
-return (1, $self->msg('e28')) unless $self->registered;
+return (1, $self->msg('e28')) unless $self->isregistered;
 
 my @bad;
 if (@bad = BadWords::check($line)) {   
@@ -36,14 +38,27 @@ return (1, $self->msg('dx2')) unless @f >= 2;
 # can be in any order
 
 if ($f[0] =~ /^by$/i) {
-       return (1, $self->msg('e5')) unless $main::allowdxby || $self->priv;
+       return (1, $self->msg('e5')) unless $main::allowdxby || $self->priv > 1;
     $spotter = uc $f[1];
-    $line =~ s/\s*$f[0]\s+$f[1]\s+//;
-#      $line = $f[2];
+    $line =~ s/^\s*$f[0]\s+$f[1]\s+//;
        @f = split /\s+/, $line, 3;
        return (1, $self->msg('dx2')) unless @f >= 2;
 }
 
+my $ipaddr;
+@f = split /\s+/, $line, 3;
+if ($f[0] eq 'ip') {
+       return (1, $self->msg('e5')) unless $spotter &&  $self->priv > 1;
+       if (is_ipaddr($f[1])) {
+               $ipaddr = $f[1];
+       } else {
+               return (1, $self->msg('dx3', $f[1]));
+       }
+       $line =~ s/^\s*$f[0]\s+$f[1]\s+//;
+       @f = split /\s+/, $line, 3;
+}
+
+
 # get the freq and callsign either way round
 if (is_freq($f[1]) && $f[0] =~ m{^[\w\d]+(?:/[\w\d]+){0,2}$}) {
        $spotted = uc $f[0];
@@ -54,13 +69,14 @@ if (is_freq($f[1]) && $f[0] =~ m{^[\w\d]+(?:/[\w\d]+){0,2}$}) {
 } else {
        return (1, $self->msg('dx3'));
 }
+$line =~ s/^\s*$f[0]\s+$f[1]\s+//;
+$line =~ s/\t+/ /g;                            # do this here because it needs to be stopped ASAP!
+$line ||= ' ';
 
-
-my $ipaddr;
 my $addr = $self->hostname;
-
 if ($self->conn && $self->conn->peerhost) {
-       $ipaddr = $addr unless !is_ipaddr($addr) || $addr =~ /^127\./ || $addr =~ /^::[0-9a-f]+$/;
+#      $ipaddr = $addr unless !is_ipaddr($addr) || $addr =~ /^127\./ || $addr =~ /^::[0-9a-f]+$/;
+       $ipaddr ||= $addr; # force a PC61 
 } elsif ($self->inscript) {
        $ipaddr = "script";
 }
@@ -87,10 +103,6 @@ if (($spotted =~ /$spotternoid/ || $spotted =~ /$callnoid/) && $freq < $Spot::mi
        $localonly++;
 }
 
-# make line the rest of the line
-$line = $f[2] || " ";
-@f = split /\s+/, $line;
-
 # bash down the list of bands until a valid one is reached
 my $bandref;
 my @bb;
@@ -138,9 +150,11 @@ return (1, @out) unless $valid;
 
 # Store it here (but only if it isn't baddx)
 my $t = (int ($main::systime/60)) * 60;
-return (1, $self->msg('dup')) if Spot::dup($freq, $spotted, $t, $line, $spotter);
+return (1, $self->msg('dup')) if Spot::dup($freq, $spotted, $t, $line, $spotter, $main::mycall);
 my @spot = Spot::prepare($freq, $spotted, $t, $line, $spotter, $main::mycall, $ipaddr);
 
+#$DB::single = 1;
+
 if ($freq =~ /^69/ || $localonly) {
 
        # heaven forfend that we get a 69Mhz band :-)
@@ -149,21 +163,19 @@ if ($freq =~ /^69/ || $localonly) {
        }
 
        $self->dx_spot(undef, undef, @spot);
+
        return (1);
 } else {
-       if (@spot) {
-               # store it 
+       # send orf to the users
+       $ipaddr ||= $main::mycall;      # emergency backstop
+       my $spot = DXProt::pc61($spotter, $freq, $spotted, $line,  $ipaddr);
+       
+       $self->dx_spot(undef, undef, @spot);
+       if ($self->isslugged) {
+               push @{$self->{sluggedpcs}}, [61, $spot, \@spot];
+       } else {
+               # store in spots database 
                Spot::add(@spot);
-
-               # send orf to the users
-               my $spot;
-
-               if ($ipaddr) {
-                       $spot = DXProt::pc61($spotter, $freq, $spotted, $line, $ipaddr);
-               } else {
-                       $spot = DXProt::pc11($spotter, $freq, $spotted, $line);
-               }
-
                DXProt::send_dx_spot($self, $spot, @spot);
        }
 }
@@ -172,5 +184,3 @@ return (1, @out);
 
 
 
-
-