X-Git-Url: http://gb7djk.dxcluster.net/gitweb/gitweb.cgi?a=blobdiff_plain;f=perl%2FDXProtHandle.pm;h=526762e514d623b72d8c1b18ca49e09403ac205a;hb=f44ebfb22849652844e5c4ff4e2e583cb444c2b9;hp=d7350f4e60a678f4f3d35846f8ce3943a5250d4b;hpb=c0b8fc3a5577205c33e9fe59ee18d9d020c845e1;p=spider.git

diff --git a/perl/DXProtHandle.pm b/perl/DXProtHandle.pm
index d7350f4e..526762e5 100644
--- a/perl/DXProtHandle.pm
+++ b/perl/DXProtHandle.pm
@@ -37,6 +37,9 @@ use RouteDB;
 
 use strict;
 
+use vars qw($VERSION $BRANCH);
+($VERSION, $BRANCH) = dxver(q$Revision$);
+
 use vars qw($pc11_max_age $pc23_max_age $last_pc50 $eph_restime $eph_info_restime $eph_pc34_restime
 			$last_hour $last10 %eph  %pings %rcmds $ann_to_talk
 			$pingint $obscount %pc19list $chatdupeage $chatimportfn
@@ -410,6 +413,7 @@ sub handle_16
 		dbg("PCPROT: don't send users to $self->{call}") if isdbg('chanerr');
 		return;
 	}
+
 	# is it me?
 	if ($ncall eq $main::mycall) {
 		dbg("PCPROT: trying to alter config on this node from outside!") if isdbg('chanerr');
@@ -425,11 +429,6 @@ sub handle_16
 		return;
 	}
 
-	unless ($h) {
-		dbg("PCPROT: non-local PC16, ignored") if isdbg('chanerr');
-		return;
-	}
-
 	my $parent = Route::Node::get($ncall); 
 
 	if ($parent) {
@@ -441,6 +440,15 @@ sub handle_16
 
 		# input filter if required
 		return unless $self->in_filter_route($parent);
+	} else {
+		$parent = Route::Node->new($ncall);
+	}
+
+	unless ($h) {
+		if ($parent->via_pc92) {
+			dbg("PCPROT: non-local node controlled by PC92, ignored") if isdbg('chanerr');
+			return;
+		}
 	}
 
 	my $i;
@@ -471,9 +479,10 @@ sub handle_16
 				$r->flags($flags);
 				$au = $r;
 			}
-			push @rout, $r if $au;
+			push @rout, $r if $h && $au;
 		} else {
-			push @rout, $parent->add_user($call, $flags);
+			my @ans = $parent->add_user($call, $flags);
+			push @rout, @ans if $h && @ans; 
 		}
 		
 		# send info to all logged in thingies
@@ -490,8 +499,8 @@ sub handle_16
 		$user->put;
 	}
 	if (@rout) {
-		$self->route_pc16($origin, $line, $parent, @rout);
-		$self->route_pc92a($main::mycall, undef, $parent, @rout) if $self->{state} eq 'normal';
+		$self->route_pc16($origin, $line, $parent, @rout) if @rout;
+#		$self->route_pc92a($main::mycall, undef, $parent, @rout) if $h && $self->{state} eq 'normal';
 	}
 }
 		
@@ -513,6 +522,7 @@ sub handle_17
 		dbg("PCPROT: don't send users to $self->{call}") if isdbg('chanerr');
 		return;
 	}
+
 	if ($ncall eq $main::mycall) {
 		dbg("PCPROT: trying to alter config on this node from outside!") if isdbg('chanerr');
 		return;
@@ -540,6 +550,19 @@ sub handle_17
 		return;
 	}
 
+	$dxchan = DXChannel::get($ncall);
+	unless ($dxchan) {
+		if ($parent->via_pc92) {
+			dbg("PCPROT: non-local node controlled by PC92, ignored") if isdbg('chanerr');
+			return;
+		}
+	}
+
+	if (DXChannel::get($ucall)) {
+		dbg("PCPROT: trying do disconnect local user, ignored") if isdbg('chanerr');
+		return;
+	}
+
 	# input filter if required and then remove user if present
 	if ($parent) {
 #		return unless $self->in_filter_route($parent);	
@@ -559,7 +582,7 @@ sub handle_17
 
 	$uref = Route->new($ucall) unless $uref; # throw away
 	$self->route_pc17($origin, $line, $parent, $uref);
-	$self->route_pc92d($main::mycall, undef, $parent, $uref);
+#	$self->route_pc92d($main::mycall, undef, $parent, $uref) if $dxchan;
 }
 		
 # link request
@@ -583,7 +606,8 @@ sub handle_18
 			$self->sort('S');
 		}
 		$self->{handle_xml}++ if DXXml::available() && $_[1] =~ /\bxml\b/;
-		$self->{do_pc92}++ if $_[1] =~ /\bpc92\b/;
+		my ($pc9x) = $_[1] =~ /\bpc9\[(\d+)\]\b/;
+		$self->{do_pc92}++ if (defined $pc9x && $pc9x =~ /2/) || $_[1] =~ /\bpc92\b/;
 	} else {
 		$self->version(50.0);
 		$self->version($_[2] / 100) if $_[2] && $_[2] =~ /^\d+$/;
@@ -627,7 +651,7 @@ sub handle_19
 	my $newline = "PC19^";
 
 	# new routing list
-	my @rout;
+	my (@rout, @pc92out);
 
 	# first get the INTERFACE node
 	my $parent = Route::Node::get($self->{call});
@@ -637,6 +661,8 @@ sub handle_19
 		return;
 	}
 
+	my $h;
+	
 	# parse the PC19
 	# 
 	# We are making a major change from now on. We are only going to accept
@@ -666,10 +692,15 @@ sub handle_19
 		next if $call eq $main::mycall;
 
 		# check that this PC19 isn't trying to alter the wrong dxchan
+		$h = 0;
 		my $dxchan = DXChannel::get($call);
-		if ($dxchan && $dxchan != $self) {
-			dbg("PCPROT: PC19 from $self->{call} trying to alter wrong locally connected $call, ignored!") if isdbg('chanerr');
-			next;
+		if ($dxchan) {
+			if ($dxchan == $self) {
+				$h = 1;
+			} else {
+				dbg("PCPROT: PC19 from $self->{call} trying to alter wrong locally connected $call, ignored!") if isdbg('chanerr');
+				next;
+			}
 		}
 
 		my $user = check_add_node($call);
@@ -681,9 +712,11 @@ sub handle_19
 
 		RouteDB::update($call, $self->{call}, $dxchan ? 1 : undef);
 
-		unless ($dxchan) {
-			dbg("PCPROT: PC19 not directly connected, ignored") if isdbg('chanerr');
-			next;
+		unless ($h) {
+			if ($parent->via_pc92) {
+				dbg("PCPROT: non-local node controlled by PC92, ignored") if isdbg('chanerr');
+				next;
+			}
 		}
 
 		my $r = Route::Node::get($call);
@@ -712,6 +745,7 @@ sub handle_19
 					my $ar = $parent->add($call, $ver, $flags);
 					$user->wantroutepc19(1) unless defined $user->wantroutepc19;
 					push @rout, $ar if $ar;
+					push @pc92out, $r if $h;
 				} else {
 					next;
 				}
@@ -732,7 +766,9 @@ sub handle_19
 	if (@rout) {
 		$self->route_pc21($self->{call}, $line, @rout);
 		$self->route_pc19($self->{call}, $line, @rout);
-		$self->route_pc92a($main::mycall, $line, $main::routeroot, @rout) if $self->{state} eq 'normal';
+	}
+	if (@pc92out) {
+		$self->route_pc92a($main::mycall, $line, $main::routeroot, @pc92out) if $self->{state} eq 'normal';
 	}
 }
 		
@@ -799,6 +835,11 @@ sub handle_21
 		my $node = Route::Node::get($call);
 		if ($node) {
 			
+			if ($node->via_pc92) {
+				dbg("PCPROT: controlled by PC92, ignored") if isdbg('chanerr');
+				return;
+			}
+
 			my $dxchan = DXChannel::get($call);
 			if ($dxchan && $dxchan != $self) {
 				dbg("PCPROT: PC21 from $self->{call} trying to alter locally connected $call, ignored!") if isdbg('chanerr');
@@ -819,7 +860,7 @@ sub handle_21
 
 	if (@rout) {
 		$self->route_pc21($origin, $line, @rout);
-		$self->route_pc92d($main::mycall, $line, $main::routeroot, @rout);
+#		$self->route_pc92d($main::mycall, $line, $main::routeroot, @rout);
 	}
 }
 		
@@ -1282,7 +1323,7 @@ sub _decode_pc92_call
 	my $icall = shift;
 	my @part = split /:/, $icall;
 	my ($flag, $call) = unpack "A A*", $part[0];
-	return () unless $flag && $flag ge '0' && $flag le '7';
+	return () unless defined $flag && $flag ge '0' && $flag le '7';
 	return () unless $call && is_callsign($call);
 	my $is_node = $flag & 4;
 	my $is_extnode = $flag & 2;
@@ -1318,7 +1359,7 @@ sub _add_thingy
 {
 	my $parent = shift;
 	my $s = shift;
-	my ($call, $is_node, $is_extnode, $here, $version, $build) = _decode_pc92_call($s);
+	my ($call, $is_node, $is_extnode, $here, $version, $build) = @$s;
 	my @rout;
 
 	if ($call) {
@@ -1335,7 +1376,7 @@ sub _del_thingy
 {
 	my $parent = shift;
 	my $s = shift;
-	my ($call, $is_node, $is_extnode, $here, $version, $build) = _decode_pc92_call($s);
+	my ($call, $is_node, $is_extnode, $here, $version, $build) = @$s;
 	my @rout;
 	if ($call) {
 		if ($is_node) {
@@ -1370,21 +1411,19 @@ sub check_pc9x_t
 	my $t = shift;
 	my $pc = shift;
 	my $create = shift;
-	
+
 	my $parent = ref $call ? $call : Route::Node::get($call);
 	if ($parent) {
 		my $lastid = $parent->lastid->{$pc} || 0;
-		$t += 86400 if $t < $lastid - 43200;
-		if ($lastid >= $t) {
+		if ($lastid + $main::systime_daystart >= $t + $main::systime_daystart) {
 			dbg("PCPROT: dup / old id on $call <= $lastid, ignored") if isdbg('chanerr');
 			return;
 		}
-		$t -= 86400 if $t >= 86400;
 	} elsif ($create) {
 		$parent = Route::Node->new($call);
 	}
 	$parent->lastid->{$pc} = $t;
- 
+
 	return $parent;
 }
 
@@ -1406,7 +1445,7 @@ sub handle_92
 	my $t = $_[2];
 	my $sort = $_[3];
 	
-	my @ent = grep {$_ && /^[0-7]/} @_[4 .. $#_];
+	my @ent = map {[ _decode_pc92_call($_) ]} grep {$_ && /^[0-7]/} @_[4 .. $#_];
 	
 	if ($pcall eq $main::mycall) {
 		dbg("PCPROT: looped back, ignored") if isdbg('chanerr');
@@ -1417,12 +1456,14 @@ sub handle_92
 	
 	$parent->lastid->{92} = $t;
 	$parent->do_pc92(1);
+	$parent->via_pc92(1);
+	$parent->reset_obs;
 
 	if (@ent) {
 
 		# look at the first one which will always be a node of some sort
 		# and update any information that needs to be done. 
-		my ($call, $is_node, $is_extnode, $here, $version, $build) = _decode_pc92_call($ent[0]);
+		my ($call, $is_node, $is_extnode, $here, $version, $build) = @{$ent[0]}; 
 		if ($call && $is_node) {
 			if ($call eq $main::mycall) {
 				dbg("PCPROT: looped back on node entry, ignored") if isdbg('chanerr');
@@ -1444,28 +1485,41 @@ sub handle_92
 		$parent->here(Route::here($here));
 		$parent->version($version) if $version && $version > $parent->version;
 		$parent->build($build) if $build && $build > $parent->build;
+		$parent->via_pc92(1);
+		$parent->reset_obs;
 		shift @ent;
 	}
 
+	# do a pass through removing any references to either locally connected nodes or mycall
+	my @nent;
+	for (@ent) {
+		next unless $_;
+		if ($_->[0] eq $main::mycall || DXChannel::get($_->[0])) {
+			dbg("PCPROT: $_->[0] refers to locally connected node, ignored") if isdbg('chanerr');
+			next;
+		} 
+		push @nent, $_;
+	}
+
 	my (@radd, @rdel);
 	
 	if ($sort eq 'A') {
-		for (@ent) {
+		for (@nent) {
 			push @radd, _add_thingy($parent, $_);
 		}
 	} elsif ($sort eq 'D') {
-		for (@ent) {
+		for (@nent) {
 			push @rdel, _del_thingy($parent, $_);
 		}
 	} elsif ($sort eq 'C') {
 		my (@nodes, @users);
-		for (@ent) {
-			my ($call, $is_node, $is_extnode, $here, $version, $build) = _decode_pc92_call($_);
-			if ($call) {
-				if ($is_node) {
-					push @nodes, $call;
+		foreach my $r (@nent) {
+#			my ($call, $is_node, $is_extnode, $here, $version, $build) = _decode_pc92_call($_);			
+			if ($r->[0]) {
+				if ($r->[1]) {
+					push @nodes, $r->[0];
 				} else {
-					push @users, $call;
+					push @users, $r->[0];
 				}
 			} else {
 				dbg("DXPROT: pc92 call entry '$_' not decoded, ignored") if isdbg('chanerr'); 
@@ -1474,11 +1528,11 @@ sub handle_92
 
 		my ($dnodes, $dusers, $nnodes, $nusers) = $parent->calc_config_changes(\@nodes, \@users);
 
-		for (@ent) {
-			my ($call, $is_node, $is_extnode, $here, $version, $build) = _decode_pc92_call($_);
+		foreach my $r (@nent) {
+			my $call = $r->[0];
 			if ($call) {
-				push @radd,_add_thingy($parent, $_) if grep $call eq $_, (@$nnodes, @$nusers);
-				push @rdel,_del_thingy($parent, $_) if grep $call eq $_, (@$dnodes, @$dusers);
+				push @radd,_add_thingy($parent, $r) if grep $call eq $_, (@$nnodes, @$nusers);
+				push @rdel,_del_thingy($parent, $r) if grep $call eq $_, (@$dnodes, @$dusers);
 			}
 		}
 	} else {