X-Git-Url: http://gb7djk.dxcluster.net/gitweb/gitweb.cgi?a=blobdiff_plain;f=perl%2FDXProt.pm;h=b8b17ae612065b2080eb8c44f7c34cc20120c81c;hb=1cc51a6696899a05d1b9ca40dab497cfdc39294b;hp=966f0eefb0d88f4a5f4d7d8a105329542deef3df;hpb=6624dcdf07d628e8d6a16fc6549edf40be25b7b2;p=spider.git

diff --git a/perl/DXProt.pm b/perl/DXProt.pm
index 966f0eef..b8b17ae6 100644
--- a/perl/DXProt.pm
+++ b/perl/DXProt.pm
@@ -32,10 +32,18 @@ use BadWords;
 use DXHash;
 use Route;
 use Route::Node;
+use Script;
 
 use strict;
-use vars qw($me $pc11_max_age $pc23_max_age
-			$last_hour $last10 %eph  %pings %rcmds
+
+use vars qw($VERSION $BRANCH);
+$VERSION = sprintf( "%d.%03d", q$Revision$ =~ /(\d+)\.(\d+)/ );
+$BRANCH = sprintf( "%d.%03d", q$Revision$ =~ /\d+\.\d+\.(\d+)\.(\d+)/ ) || 0;
+$main::build += $VERSION;
+$main::branch += $BRANCH;
+
+use vars qw($me $pc11_max_age $pc23_max_age $last_pc50
+			$last_hour $last10 %eph  %pings %rcmds $ann_to_talk
 			%nodehops $baddx $badspotter $badnode $censorpc
 			$allowzero $decode_dk0wcy $send_opernam @checklist);
 
@@ -52,7 +60,8 @@ $censorpc = 1;					# Do a BadWords::check on text fields and reject things
 $baddx = new DXHash "baddx";
 $badspotter = new DXHash "badspotter";
 $badnode = new DXHash "badnode";
-$last10 = time;
+$last10 = $last_pc50 = time;
+$ann_to_talk = 1;
 
 @checklist = 
 (
@@ -209,22 +218,29 @@ sub start
 	my ($self, $line, $sort) = @_;
 	my $call = $self->{call};
 	my $user = $self->{user};
+
+	# log it
+	my $host = $self->{conn}->{peerhost} || "unknown";
+	Log('DXProt', "$call connected from $host");
 	
 	# remember type of connection
 	$self->{consort} = $line;
 	$self->{outbound} = $sort eq 'O';
-	$self->{priv} = $user->priv || 1;     # other clusters can always be 'normal' users
+	my $priv = $user->priv;
+	$priv = $user->priv(1) unless $priv;
+	$self->{priv} = $priv;     # other clusters can always be 'normal' users
 	$self->{lang} = $user->lang || 'en';
 	$self->{isolate} = $user->{isolate};
 	$self->{consort} = $line;	# save the connection type
 	$self->{here} = 1;
+	$self->{width} = 80;
 
 	# get the output filters
 	$self->{spotsfilter} = Filter::read_in('spots', $call, 0) || Filter::read_in('spots', 'node_default', 0);
 	$self->{wwvfilter} = Filter::read_in('wwv', $call, 0) || Filter::read_in('wwv', 'node_default', 0);
 	$self->{wcyfilter} = Filter::read_in('wcy', $call, 0) || Filter::read_in('wcy', 'node_default', 0);
 	$self->{annfilter} = Filter::read_in('ann', $call, 0) || Filter::read_in('ann', 'node_default', 0) ;
-	$self->{routefilter} = Filter::read_in('route', $call, 0) || Filter::read_in('route', 'node_default', 0) ;
+	$self->{routefilter} = Filter::read_in('route', $call, 0) || Filter::read_in('route', 'node_default', 0) unless $self->{isolate} ;
 
 
 	# get the INPUT filters (these only pertain to Clusters)
@@ -232,7 +248,7 @@ sub start
 	$self->{inwwvfilter} = Filter::read_in('wwv', $call, 1) || Filter::read_in('wwv', 'node_default', 1);
 	$self->{inwcyfilter} = Filter::read_in('wcy', $call, 1) || Filter::read_in('wcy', 'node_default', 1);
 	$self->{inannfilter} = Filter::read_in('ann', $call, 1) || Filter::read_in('ann', 'node_default', 1);
-	$self->{inroutefilter} = Filter::read_in('route', $call, 1) || Filter::read_in('route', 'node_default', 1);
+	$self->{inroutefilter} = Filter::read_in('route', $call, 1) || Filter::read_in('route', 'node_default', 1) unless $self->{isolate};
 	
 	# set unbuffered and no echo
 	$self->send_now('B',"0");
@@ -244,22 +260,23 @@ sub start
 	$self->{pingint} = $ping;
 	$self->{nopings} = $user->nopings || 2;
 	$self->{pingtime} = [ ];
-	$self->{pingave} = 0;
+	$self->{pingave} = 999;
+	$self->{lastping} = $main::systime;
 
 	# send initialisation string
 	unless ($self->{outbound}) {
 		$self->send(pc18());
-		$self->{lastping} = $main::systime;
-	} else {
-		$self->{lastping} = $main::systime + ($self->pingint / 2);
 	}
+	
 	$self->state('init');
 	$self->{pc50_t} = $main::systime;
 
 	# send info to all logged in thingies
 	$self->tell_login('loginn');
 
-	Log('DXProt', "$call connected");
+	# run a script send the output to the debug file
+	my $script = new Script(lc $call) || new Script('node_default');
+	$script->run($self) if $script;
 }
 
 #
@@ -309,20 +326,50 @@ sub normal
 			}
 
 			# is it for me or one of mine?
-			my ($to, $via, $call, $dxchan);
+			my ($from, $to, $via, $call, $dxchan);
+			$from = $field[1];
 			if ($field[5] gt ' ') {
-				$call = $via = $field[2];
+				$via = $field[2];
 				$to = $field[5];
 			} else {
-				$call = $to = $field[2];
+				$to = $field[2];
 			}
-			$dxchan = DXChannel->get($main::myalias) if $call eq $main::mycall;
-			$dxchan = DXChannel->get($call) unless $dxchan;
+
+			# if we are converting announces to talk is it a dup?
+			if ($ann_to_talk) {
+				if (AnnTalk::is_talk_candidate($from, $field[3]) && AnnTalk::dup($from, $to, $field[3])) {
+					dbg("DXPROT: Dupe talk from announce, dropped") if isdbg('chanerr');
+					return;
+				}
+			}
+
+			# it is here and logged on
+			$dxchan = DXChannel->get($main::myalias) if $to eq $main::mycall;
+			$dxchan = DXChannel->get($to) unless $dxchan;
 			if ($dxchan && $dxchan->is_user) {
 				$field[3] =~ s/\%5E/^/g;
-				$dxchan->talk($field[1], $to, $via, $field[3]);
-			} else {
-				$self->route($field[2], $line); # relay it on its way
+				$dxchan->talk($from, $to, $via, $field[3]);
+				return;
+			}
+
+			# is it elsewhere, visible on the cluster via the to address?
+			# note: this discards the via unless the to address is on
+			# the via address
+			my ($ref, $vref);
+			if ($ref = Route::get($to)) {
+				$vref = Route::Node::get($via) if $via;
+				$vref = undef unless $vref && grep $to eq $_, $vref->users;
+				$ref->dxchan->talk($from, $to, $vref ? $via : undef, $field[3], $field[6]);
+				return;
+			}
+
+			# not visible here, send a message of condolence
+			$vref = undef;
+			$ref = Route::get($from);
+			$vref = $ref = Route::Node::get($field[6]) unless $ref; 
+			if ($ref) {
+				$dxchan = $ref->dxchan;
+				$dxchan->talk($main::mycall, $from, $vref ? $vref->call : undef, $dxchan->msg('talknh', $to) );
 			}
 			return;
 		}
@@ -406,7 +453,7 @@ sub normal
 			my $user = DXUser->get_current($spot[4]);
 			if ($user) {
 				my $qra = $user->qra;
-				unless ($qra && DXBearing::is_qra($qra)) {
+				unless ($qra && is_qra($qra)) {
 					my $lat = $user->lat;
 					my $long = $user->long;
 					if (defined $lat && defined $long) {
@@ -422,7 +469,7 @@ sub normal
 					my $node;
 					my $to = $user->homenode;
 					my $last = $user->lastoper || 0;
-					if ($to ne $main::mycall && $send_opernam && $main::systime > $last + $DXUser::lastoperinterval && $to && ($node = Route::Node::get($to)) ) {
+					if ($send_opernam && $to && $to ne $main::mycall && $main::systime > $last + $DXUser::lastoperinterval && ($node = Route::Node::get($to)) ) {
 						my $cmd = "forward/opernam $spot[4]";
 						# send the rcmd but we aren't interested in the replies...
 						my $dxchan = $node->dxchan;
@@ -480,38 +527,29 @@ sub normal
 					return;
 				}
 			}
-			
+
 			if ($field[2] eq '*' || $field[2] eq $main::mycall) {
-				
-				# global ann filtering on INPUT
-				if ($self->{inannfilter}) {
-					my ($ann_dxcc, $ann_itu, $ann_cq, $org_dxcc, $org_itu, $org_cq) = (0..0);
-					my @dxcc = Prefix::extract($field[1]);
-					if (@dxcc > 0) {
-						$ann_dxcc = $dxcc[1]->dxcc;
-						$ann_itu = $dxcc[1]->itu;
-						$ann_cq = $dxcc[1]->cq();						
-					}
-					@dxcc = Prefix::extract($field[5]);
-					if (@dxcc > 0) {
-						$org_dxcc = $dxcc[1]->dxcc;
-						$org_itu = $dxcc[1]->itu;
-						$org_cq = $dxcc[1]->cq();						
-					}
-					my ($filter, $hops) = $self->{inannfilter}->it(@field[1..6], $self->{call}, 
-													$ann_dxcc, $ann_itu, $ann_cq, $org_dxcc, $org_itu, $org_cq);
-					unless ($filter) {
-						dbg("PCPROT: Rejected by input announce filter") if isdbg('chanerr');
-						return;
+
+
+				# here's a bit of fun, convert incoming ann with a callsign in the first word
+				# or one saying 'to <call>' to a talk if we can route to the recipient
+				if ($ann_to_talk) {
+					my $call = AnnTalk::is_talk_candidate($field[1], $field[3]);
+					if ($call) {
+						my $ref = Route::get($call);
+						if ($ref) {
+							my $dxchan = $ref->dxchan;
+							$dxchan->talk($field[1], $call, undef, $field[3], $field[5]) if $dxchan != $self;
+							return;
+						}
 					}
 				}
-
+	
 				# send it
 				$self->send_announce($line, @field[1..6]);
 			} else {
 				$self->route($field[2], $line);
 			}
-			
 			return;
 		}
 		
@@ -556,10 +594,20 @@ sub normal
 				my ($call, $conf, $here) = $field[$i] =~ /^(\S+) (\S) (\d)/o;
 				next unless $call && $conf && defined $here && is_callsign($call);
 				next if $call eq $main::mycall;
+
+				eph_del_regex("^PC17\^$call\^$ncall");
 				
 				$conf = $conf eq '*';
 
-				my $r = Route::User::get($call);
+				# reject this if we think it is a node already
+				my $r = Route::Node::get($call);
+				my $u = DXUser->get_current($call) unless $r;
+				if ($r || ($u && $u->is_node)) {
+					dbg("PCPROT: $call is a node") if isdbg('chanerr');
+					next;
+				}
+				
+				$r = Route::User::get($call);
 				my $flags = Route::here($here)|Route::conf($conf);
 				
 				if ($r) {
@@ -567,7 +615,7 @@ sub normal
 						$r->flags($flags);
 						push @rout, $r;
 					}
-					$r->addparent($ncall);
+					$r->addparent($parent);
 				} else {
 					push @rout, $parent->add_user($call, $flags);
 				}
@@ -582,6 +630,10 @@ sub normal
 				$user->put;
 			}
 
+			if (eph_dup($line)) {
+				dbg("PCPROT: dup PC16 detected") if isdbg('chanerr');
+				return;
+			}
 			
 			# queue up any messages (look for privates only)
 			DXMsg::queue_msg(1) if $self->state eq 'normal';     
@@ -594,6 +646,9 @@ sub normal
 			my $dxchan;
 			my $ncall = $field[2];
 			my $ucall = $field[1];
+
+			eph_del_regex("^PC16.*$ncall.*$ucall");
+			
 			if ($ncall eq $main::mycall) {
 				dbg("PCPROT: trying to alter config on this node from outside!") if isdbg('chanerr');
 				return;
@@ -603,16 +658,28 @@ sub normal
 				dbg("PCPROT: PC17 from $self->{call} trying to alter locally connected $ncall, ignored!") if isdbg('chanerr');
 				return;
 			}
+
+			my $uref = Route::User::get($ucall);
+			unless ($uref) {
+				dbg("PCPROT: Route::User $ucall not in config") if isdbg('chanerr');
+				return;
+			}
 			my $parent = Route::Node::get($ncall);
 			unless ($parent) {
 				dbg("PCPROT: Route::Node $ncall not in config") if isdbg('chanerr');
 				return;
-			}
+			}			
 
 			# input filter if required
 			return unless $self->in_filter_route($parent);
+			
+			my @rout = $parent->del_user($uref);
+
+			if (eph_dup($line)) {
+				dbg("PCPROT: dup PC17 detected") if isdbg('chanerr');
+				return;
+			}
 
-			my @rout = $parent->del_user($ucall);
 			$self->route_pc17($parent, @rout) if @rout;
 			return;
 		}
@@ -623,7 +690,7 @@ sub normal
 			# first clear out any nodes on this dxchannel
 			my $parent = Route::Node::get($self->{call});
 			my @rout = $parent->del_nodes;
-			$self->route_pc21(@rout, $parent);
+			$self->route_pc21(@rout, $parent) if @rout;
 			$self->send_local_config();
 			$self->send(pc20());
 			return;             # we don't pass these on
@@ -649,6 +716,9 @@ sub normal
 				my $conf = $field[$i+2];
 				my $ver = $field[$i+3];
 				next unless defined $here && defined $conf && is_callsign($call);
+
+				eph_del_regex("^PC(?:21\^$call|17\^[^\^]+\^$call)");
+				
 				# check for sane parameters
 				$ver = 5000 if $ver eq '0000';
 				next if $ver < 5000; # only works with version 5 software
@@ -698,7 +768,7 @@ sub normal
 					$user = DXUser->new($call);
 					$user->sort('A');
 					$user->priv(1);                   # I have relented and defaulted nodes
-					$self->{priv} = 1;                # to user RCMDs allowed
+					$user->lockout(1);
 					$user->homenode($call);
 					$user->node($call);
 				}
@@ -706,6 +776,11 @@ sub normal
 				$user->put;
 			}
 
+			if (eph_dup($line)) {
+				dbg("PCPROT: dup PC19 detected") if isdbg('chanerr');
+				return;
+			}
+
 			$self->route_pc19(@rout) if @rout;
 			return;
 		}
@@ -714,11 +789,15 @@ sub normal
 			$self->send_local_config();
 			$self->send(pc22());
 			$self->state('normal');
+			$self->{lastping} = 0;
 			return;
 		}
 		
 		if ($pcno == 21) {		# delete a cluster from the list
 			my $call = uc $field[1];
+
+			eph_del_regex("^PC1[79].*$call");
+			
 			my @rout;
 			my $parent = Route::Node::get($self->{call});
 			unless ($parent) {
@@ -744,12 +823,19 @@ sub normal
 				dbg("PCPROT: I WILL _NOT_ be disconnected!") if isdbg('chanerr');
 				return;
 			}
+
+			if (eph_dup($line)) {
+				dbg("PCPROT: dup PC21 detected") if isdbg('chanerr');
+				return;
+			}
+
 			$self->route_pc21(@rout) if @rout;
 			return;
 		}
 		
 		if ($pcno == 22) {
 			$self->state('normal');
+			$self->{lastping} = 0;
 			return;
 		}
 				
@@ -824,7 +910,7 @@ sub normal
 				return;
 			}
 
-			Log('DXProt', "Merge request for $field[3] spots and $field[4] WWV from $field[1]");
+			Log('DXProt', "Merge request for $field[3] spots and $field[4] WWV from $field[2]");
 			
 			# spots
 			if ($field[3] > 0) {
@@ -856,60 +942,12 @@ sub normal
 		}
 		
 		if ($pcno == 34 || $pcno == 36) { # remote commands (incoming)
-			if ($field[1] eq $main::mycall) {
-				my $ref = DXUser->get_current($field[2]);
-				my $cref = Route::Node::get($field[2]);
-				Log('rcmd', 'in', $ref->{priv}, $field[2], $field[3]);
-				unless (!$cref || !$ref || $cref->call ne $ref->homenode) {    # not allowed to relay RCMDS!
-					if ($ref->{priv}) {	# you have to have SOME privilege, the commands have further filtering
-						$self->{remotecmd} = 1; # for the benefit of any command that needs to know
-						my $oldpriv = $self->{priv};
-						$self->{priv} = $ref->{priv};     # assume the user's privilege level
-						my @in = (DXCommandmode::run_cmd($self, $field[3]));
-						$self->{priv} = $oldpriv;
-						for (@in) {
-							s/\s*$//og;
-							$self->send(pc35($main::mycall, $field[2], "$main::mycall:$_"));
-							Log('rcmd', 'out', $field[2], $_);
-						}
-						delete $self->{remotecmd};
-					} else {
-						$self->send(pc35($main::mycall, $field[2], "$main::mycall:sorry...!"));
-					}
-				} else {
-					$self->send(pc35($main::mycall, $field[2], "$main::mycall:your attempt is logged, Tut tut tut...!"));
-				}
-			} else {
-				my $ref = DXUser->get_current($field[1]);
-				if ($ref && $ref->is_clx) {
-					$self->route($field[1], pc84($field[2], $field[1], $field[2], $field[3]));
-				} else {
-					$self->route($field[1], $line);
-				}
-			}
+			$self->process_rcmd($field[1], $field[2], $field[2], $field[3]);
 			return;
 		}
 		
 		if ($pcno == 35) {		# remote command replies
-			if ($field[1] eq $main::mycall) {
-				my $s = $rcmds{$field[2]};
-				if ($s) {
-					my $dxchan = DXChannel->get($s->{call});
-					$dxchan->send($field[3]) if $dxchan;
-					delete $rcmds{$field[2]} if !$dxchan;
-				} else {
-					# send unsolicited ones to the sysop
-					my $dxchan = DXChannel->get($main::myalias);
-					$dxchan->send($field[3]) if $dxchan;
-				}
-			} else {
-				my $ref = DXUser->get_current($field[1]);
-				if ($ref && $ref->is_clx) {
-					$self->route($field[1], pc85($field[2], $field[1], $field[2], $field[3]));
-				} else {
-					$self->route($field[1], $line);
-				}
-			}
+			$self->process_rcmd_reply($field[1], $field[2], $field[1], $field[3]);
 			return;
 		}
 		
@@ -922,6 +960,7 @@ sub normal
 		if ($pcno == 39) {		# incoming disconnect
 			if ($field[1] eq $self->{call}) {
 				$self->disconnect(1);
+				eph_del_regex("^PC(?:1[679]|21).*$field[1]");
 			} else {
 				dbg("PCPROT: came in on wrong channel") if isdbg('chanerr');
 			}
@@ -929,8 +968,18 @@ sub normal
 		}
 		
 		if ($pcno == 41) {		# user info
-			# add this station to the user database, if required
 			my $call = $field[1];
+
+			# input filter if required
+#			my $ref = Route::get($call) || Route->new($call);
+#			return unless $self->in_filter_route($ref);
+
+			if ($field[3] eq $field[2] || $field[3] =~ /^\s*$/) {
+				dbg('PCPROT: invalid value') if isdbg('chanerr');
+				return;
+			}
+
+			# add this station to the user database, if required
 			my $user = DXUser->get_current($call);
 			$user = DXUser->new($call) if !$user;
 			
@@ -939,22 +988,34 @@ sub normal
 			} elsif ($field[2] == 2) {
 				$user->qth($field[3]);
 			} elsif ($field[2] == 3) {
-				my ($lat, $long) = DXBearing::stoll($field[3]);
-				$user->lat($lat);
-				$user->long($long);
-				$user->qra(DXBearing::lltoqra($lat, $long)) unless $user->qra && DXBearing::is_qra($user->qra);
+				if (is_latlong($field[3])) {
+					my ($lat, $long) = DXBearing::stoll($field[3]);
+					$user->lat($lat);
+					$user->long($long);
+					$user->qra(DXBearing::lltoqra($lat, $long));
+				} else {
+					dbg('PCPROT: not a valid lat/long') if isdbg('chanerr');
+					return;
+				}
 			} elsif ($field[2] == 4) {
 				$user->homenode($field[3]);
+			} elsif ($field[2] == 5) {
+				if (is_qra($field[3])) {
+					my ($lat, $long) = DXBearing::qratoll($field[3]);
+					$user->lat($lat);
+					$user->long($long);
+					$user->qra($field[3]);
+				} else {
+					dbg('PCPROT: not a valid QRA locator') if isdbg('chanerr');
+					return;
+				}
 			}
 			$user->lastoper($main::systime);   # to cut down on excessive for/opers being generated
 			$user->put;
-			my $ref = Route::get($call) || Route->new($call);
 
-			# input filter if required
-			return unless $self->in_filter_route($ref);
-
-			$self->route_pc41($ref, $call, $field[2], $field[3], $field[4]) if $ref && !eph_dup($line);
-			return;
+#  perhaps this IS what we want after all
+#			$self->route_pc41($ref, $call, $field[2], $field[3], $field[4]);
+#			return;
 		}
 
 		if ($pcno == 43) {
@@ -985,6 +1046,7 @@ sub normal
 			my $to = $field[1];
 			my $from = $field[2];
 			my $flag = $field[3];
+
 			
 			# is it for us?
 			if ($to eq $main::mycall) {
@@ -1006,20 +1068,37 @@ sub normal
 								$dxchan->send($dxchan->msg('pingi', $from, $s, $ave))
 							} elsif ($dxchan->is_node) {
 								if ($tochan) {
-									$tochan->{nopings} = $tochan->user->nopings || 2; # pump up the timer
+									my $nopings = $tochan->user->nopings || 2;
 									push @{$tochan->{pingtime}}, $t;
 									shift @{$tochan->{pingtime}} if @{$tochan->{pingtime}} > 6;
-									my $st;
-									for (@{$tochan->{pingtime}}) {
-										$st += $_;
+
+									# cope with a missed ping, this means you must set the pingint large enough
+									if ($t > $tochan->{pingint}  && $t < 2 * $tochan->{pingint} ) {
+										$t -= $tochan->{pingint};
+									}
+
+									# calc smoothed RTT a la TCP
+									if (@{$tochan->{pingtime}} == 1) {
+										$tochan->{pingave} = $t;
+									} else {
+										$tochan->{pingave} = $tochan->{pingave} + (($t - $tochan->{pingave}) / 6);
 									}
-									$tochan->{pingave} = $st / @{$tochan->{pingtime}};
+#									my $st;
+#									for (@{$tochan->{pingtime}}) {
+#										$st += $_;
+#									}
+#									$tochan->{pingave} = $st / @{$tochan->{pingtime}};
+									$tochan->{nopings} = $nopings; # pump up the timer
 								}
 							} 
 						}
 					}
 				}
 			} else {
+				if (eph_dup($line)) {
+					dbg("PCPROT: dup PC51 detected") if isdbg('chanerr');
+					return;
+				}
 				# route down an appropriate thingy
 				$self->route($to, $line);
 			}
@@ -1064,67 +1143,13 @@ sub normal
 		}
 
 		if ($pcno == 84) { # remote commands (incoming)
-			my $call = $field[1];
-			if ($call eq $main::mycall) {
-				my $ref = DXUser->get_current($field[2]);
-				my $cref = Route::Node::get($field[2]);
-				Log('rcmd', 'in', $ref->{priv}, $field[2], $field[4]);
-				unless ($field[4] =~ /rcmd/i || !$cref || !$ref || $cref->call ne $ref->homenode) {    # not allowed to relay RCMDS!
-					if ($ref->{priv}) {	# you have to have SOME privilege, the commands have further filtering
-						$self->{remotecmd} = 1; # for the benefit of any command that needs to know
-						my $oldpriv = $self->{priv};
-						$self->{priv} = $ref->{priv};     # assume the user's privilege level
-						my @in = (DXCommandmode::run_cmd($self, $field[4]));
-						$self->{priv} = $oldpriv;
-						for (@in) {
-							s/\s*$//og;
-							$self->send(pc85($main::mycall, $field[2], $field[3], "$main::mycall:$_"));
-							Log('rcmd', 'out', $field[2], $_);
-						}
-						delete $self->{remotecmd};
-					} else {
-						$self->send(pc85($main::mycall, $field[2], $field[3], "$main::mycall:sorry...!"));
-					}
-				} else {
-					$self->send(pc85($main::mycall, $field[2], $field[3],"$main::mycall:your attempt is logged, Tut tut tut...!"));
-				}
-			} else {
-				my $ref = DXUser->get_current($call);
-				if ($ref && $ref->is_clx) {
-					$self->route($call, $line);
-				} else {
-					$self->route($call, pc34($field[2], $call, $field[4]));
-				}
-			}
+			$self->process_rcmd($field[1], $field[2], $field[3], $field[4]);
 			return;
 		}
 
 		if ($pcno == 85) {		# remote command replies
-			my $call = $field[1];
-			if ($call eq $main::mycall) {
-				my $dxchan = DXChannel->get($field[3]);
-				if ($dxchan) {
-					$dxchan->send($field[4]);
-				} else {
-					my $s = $rcmds{$field[2]};
-					if ($s) {
-						$dxchan = DXChannel->get($s->{call});
-						$dxchan->send($field[4]) if $dxchan;
-						delete $rcmds{$field[2]} if !$dxchan;
-					} else {
-						# send unsolicited ones to the sysop
-						my $dxchan = DXChannel->get($main::myalias);
-						$dxchan->send($field[4]) if $dxchan;
-					}
-				}
-			} else {
-				my $ref = DXUser->get_current($call);
-				if ($ref && $ref->is_clx) {
-					$self->route($call, $line);
-				} else {
-					$self->route($call, pc35($field[2], $call, $field[4]));
-				}
-			}
+			$self->process_rcmd_reply($field[1], $field[2], $field[3], $field[4]);
+			
 			return;
 		}
 	}
@@ -1155,20 +1180,22 @@ sub process
 	my $t = time;
 	my @dxchan = DXChannel->get_all();
 	my $dxchan;
+	my $pc50s;
 	
+	# send out a pc50 on EVERY channel all at once
+	if ($t >= $last_pc50 + $DXProt::pc50_interval) {
+		$pc50s = pc50($me, scalar DXChannel::get_all_users);
+		eph_dup($pc50s);
+		$last_pc50 = $t;
+	}
+
 	foreach $dxchan (@dxchan) {
 		next unless $dxchan->is_node();
 		next if $dxchan == $me;
-		
-		# send a pc50 out on this channel
-		$dxchan->{pc50_t} = $main::systime unless exists $dxchan->{pc50_t};
-		if ($t >= $dxchan->{pc50_t} + $DXProt::pc50_interval) {
-			my $s = pc50($me, scalar DXChannel::get_all_users);
-			eph_dup($s);
-			$dxchan->send($s);
-			$dxchan->{pc50_t} = $t;
-		} 
 
+		# send the pc50
+		$dxchan->send($pc50s) if $pc50s;
+		
 		# send a ping out on this channel
 		if ($dxchan->{pingint} && $t >= $dxchan->{pingint} + $dxchan->{lastping}) {
 			if ($dxchan->{nopings} <= 0) {
@@ -1214,7 +1241,7 @@ sub send_dx_spot
 	# taking into account filtering and so on
 	foreach $dxchan (@dxchan) {
 		next if $dxchan == $me;
-		next if $dxchan == $self;
+		next if $dxchan == $self && $self->is_node;
 		$dxchan->dx_spot($line, $self->{isolate}, @_, $self->{call});
 	}
 }
@@ -1230,7 +1257,7 @@ sub dx_spot
 		($filter, $hops) = $self->{spotsfilter}->it(@_);
 		return unless $filter;
 	}
-	send_prot_line($self, $filter, $hops, $isolate, $line)
+	send_prot_line($self, $filter, $hops, $isolate, $line);
 }
 
 sub send_prot_line
@@ -1243,10 +1270,10 @@ sub send_prot_line
 		$routeit =~ s/\^H\d+\^\~$/\^H$hops\^\~/;
 	} else {
 		$routeit = adjust_hops($self, $line);  # adjust its hop count by node name
-		next unless $routeit;
+		return unless $routeit;
 	}
 	if ($filter) {
-		$self->send($routeit) if $routeit;
+		$self->send($routeit);
 	} else {
 		$self->send($routeit) unless $self->{isolate} || $isolate;
 	}
@@ -1260,13 +1287,13 @@ sub send_wwv_spot
 	my @dxchan = DXChannel->get_all();
 	my $dxchan;
 	my ($wwv_dxcc, $wwv_itu, $wwv_cq, $org_dxcc, $org_itu, $org_cq) = (0..0);
-	my @dxcc = Prefix::extract($_[7]);
+	my @dxcc = Prefix::extract($_[6]);
 	if (@dxcc > 0) {
 		$wwv_dxcc = $dxcc[1]->dxcc;
 		$wwv_itu = $dxcc[1]->itu;
 		$wwv_cq = $dxcc[1]->cq;						
 	}
-	@dxcc = Prefix::extract($_[8]);
+	@dxcc = Prefix::extract($_[7]);
 	if (@dxcc > 0) {
 		$org_dxcc = $dxcc[1]->dxcc;
 		$org_itu = $dxcc[1]->itu;
@@ -1276,8 +1303,8 @@ sub send_wwv_spot
 	# send it if it isn't the except list and isn't isolated and still has a hop count
 	# taking into account filtering and so on
 	foreach $dxchan (@dxchan) {
-		next if $dxchan == $self;
 		next if $dxchan == $me;
+		next if $dxchan == $self && $self->is_node;
 		my $routeit;
 		my ($filter, $hops);
 
@@ -1307,13 +1334,13 @@ sub send_wcy_spot
 	my @dxchan = DXChannel->get_all();
 	my $dxchan;
 	my ($wcy_dxcc, $wcy_itu, $wcy_cq, $org_dxcc, $org_itu, $org_cq) = (0..0);
-	my @dxcc = Prefix::extract($_[11]);
+	my @dxcc = Prefix::extract($_[10]);
 	if (@dxcc > 0) {
 		$wcy_dxcc = $dxcc[1]->dxcc;
 		$wcy_itu = $dxcc[1]->itu;
 		$wcy_cq = $dxcc[1]->cq;						
 	}
-	@dxcc = Prefix::extract($_[12]);
+	@dxcc = Prefix::extract($_[11]);
 	if (@dxcc > 0) {
 		$org_dxcc = $dxcc[1]->dxcc;
 		$org_itu = $dxcc[1]->itu;
@@ -1367,8 +1394,7 @@ sub send_announce
 		$to = '';
 	}
 	$target = "ALL" if !$target;
-	
-	Log('ann', $target, $_[0], $text);
+
 
 	# obtain country codes etc 
 	my ($ann_dxcc, $ann_itu, $ann_cq, $org_dxcc, $org_itu, $org_cq) = (0..0);
@@ -1385,15 +1411,25 @@ sub send_announce
 		$org_cq = $dxcc[1]->cq;						
 	}
 
+	if ($self->{inannfilter}) {
+		my ($filter, $hops) = 
+			$self->{inannfilter}->it(@_, $self->{call}, 
+									 $ann_dxcc, $ann_itu, $ann_cq,
+									 $org_dxcc, $org_itu, $org_cq);
+		unless ($filter) {
+			dbg("PCPROT: Rejected by input announce filter") if isdbg('chanerr');
+			return;
+		}
+	}
+
+	Log('ann', $target, $_[0], $text);
+
 	# send it if it isn't the except list and isn't isolated and still has a hop count
 	# taking into account filtering and so on
 	foreach $dxchan (@dxchan) {
-		next if $dxchan == $self;
 		next if $dxchan == $me;
-		my $routeit;
-		my ($filter, $hops);
-
-		$dxchan->announce($line, $self->{isolate}, $to, $target, $text, @_, $self->{call}, $ann_dxcc, $ann_itu, $ann_cq, $org_dxcc, $org_itu, $org_cq)
+		next if $dxchan == $self && $self->is_node;
+		$dxchan->announce($line, $self->{isolate}, $to, $target, $text, @_, $self->{call}, $ann_dxcc, $ann_itu, $ann_cq, $org_dxcc, $org_itu, $org_cq);
 	}
 }
 
@@ -1404,6 +1440,7 @@ sub announce
 	my $isolate = shift;
 	my $to = shift;
 	my $target = shift;
+	my $text = shift;
 	my ($filter, $hops);
 
 	if ($self->{annfilter}) {
@@ -1431,7 +1468,7 @@ sub send_local_config
 		# create a list of all the nodes that are not connected to this connection
 		# and are not themselves isolated, this to make sure that isolated nodes
         # don't appear outside of this node
-		my @dxchan = grep { $_->call ne $main::mycall && $_->call ne $self->{call} } DXChannel::get_all_nodes();
+		my @dxchan = grep { $_->call ne $main::mycall && $_ != $self && !$_->{isolate} } DXChannel::get_all_nodes();
 		@localnodes = map { my $r = Route::Node::get($_->{call}); $r ? $r : () } @dxchan if @dxchan;
 		my @intcalls = map { $_->nodes } @localnodes if @localnodes;
 		my $ref = Route::Node::get($self->{call});
@@ -1651,6 +1688,81 @@ sub addping
 	$pings{$to} = $ref;
 }
 
+sub process_rcmd
+{
+	my ($self, $tonode, $fromnode, $user, $cmd) = @_;
+	if ($tonode eq $main::mycall) {
+		my $ref = DXUser->get_current($fromnode);
+		my $cref = Route::Node::get($fromnode);
+		Log('rcmd', 'in', $ref->{priv}, $fromnode, $cmd);
+		if ($cmd !~ /^\s*rcmd/i && $cref && $ref && $cref->call eq $ref->homenode) { # not allowed to relay RCMDS!
+			if ($ref->{priv}) {		# you have to have SOME privilege, the commands have further filtering
+				$self->{remotecmd} = 1; # for the benefit of any command that needs to know
+				my $oldpriv = $self->{priv};
+				$self->{priv} = $ref->{priv}; # assume the user's privilege level
+				my @in = (DXCommandmode::run_cmd($self, $cmd));
+				$self->{priv} = $oldpriv;
+				$self->send_rcmd_reply($main::mycall, $fromnode, $user, @in);
+				delete $self->{remotecmd};
+			} else {
+				$self->send_rcmd_reply($main::mycall, $fromnode, $user, "sorry...!");
+			}
+		} else {
+			$self->send_rcmd_reply($main::mycall, $fromnode, $user, "your attempt is logged, Tut tut tut...!");
+		}
+	} else {
+		my $ref = DXUser->get_current($tonode);
+		if ($ref && $ref->is_clx) {
+			$self->route($tonode, pc84($fromnode, $tonode, $user, $cmd));
+		} else {
+			$self->route($tonode, pc34($fromnode, $tonode, $cmd));
+		}
+	}
+}
+
+sub process_rcmd_reply
+{
+	my ($self, $tonode, $fromnode, $user, $line) = @_;
+	if ($tonode eq $main::mycall) {
+		my $s = $rcmds{$fromnode};
+		if ($s) {
+			my $dxchan = DXChannel->get($s->{call});
+			my $ref = $user eq $tonode ? $dxchan : (DXChannel->get($user) || $dxchan);
+			$ref->send($line) if $ref;
+			delete $rcmds{$fromnode} if !$dxchan;
+		} else {
+			# send unsolicited ones to the sysop
+			my $dxchan = DXChannel->get($main::myalias);
+			$dxchan->send($line) if $dxchan;
+		}
+	} else {
+		my $ref = DXUser->get_current($tonode);
+		if ($ref && $ref->is_clx) {
+			$self->route($tonode, pc85($fromnode, $tonode, $user, $line));
+		} else {
+			$self->route($tonode, pc35($fromnode, $tonode, $line));
+		}
+	}
+}
+
+sub send_rcmd_reply
+{
+	my $self = shift;
+	my $tonode = shift;
+	my $fromnode = shift;
+	my $user = shift;
+	while (@_) {
+		my $line = shift;
+		$line =~ s/\s*$//;
+		Log('rcmd', 'out', $fromnode, $line);
+		if ($self->is_clx) {
+			$self->send(pc85($main::mycall, $fromnode, $user, "$main::mycall:$line"));
+		} else {
+			$self->send(pc35($main::mycall, $fromnode, "$main::mycall:$line"));
+		}
+	}
+}
+
 # add a rcmd request to the rcmd queues
 sub addrcmd
 {
@@ -1677,6 +1789,8 @@ sub disconnect
 	my $pc39flag = shift;
 	my $call = $self->call;
 
+	return if $self->{disconnecting}++;
+	
 	unless ($pc39flag && $pc39flag == 1) {
 		$self->send_now("D", DXProt::pc39($main::mycall, $self->msg('disc1', "System Op")));
 	}
@@ -1685,7 +1799,6 @@ sub disconnect
 	my $node = Route::Node::get($call);
 	my @rout;
 	if ($node) {
-		@rout = $node->del_nodes;    # at the next level
 		@rout = $node->del($main::routeroot);
 	}
 	
@@ -1718,11 +1831,11 @@ sub disconnect
 #
 sub talk
 {
-	my ($self, $from, $to, $via, $line) = @_;
+	my ($self, $from, $to, $via, $line, $origin) = @_;
 	
 	$line =~ s/\^/\\5E/g;			# remove any ^ characters
-	$self->send(DXProt::pc10($from, $to, $via, $line));
-	Log('talk', $self->call, $from, $via?$via:$main::mycall, $line);
+	$self->send(DXProt::pc10($from, $to, $via, $line, $origin));
+	Log('talk', $self->call, $from, $via?$via:$main::mycall, $line) unless $origin && $origin ne $main::mycall;
 }
 
 # send it if it isn't the except list and isn't isolated and still has a hop count
@@ -1739,7 +1852,7 @@ sub send_route
 	for (; @_ && $no; $no--) {
 		my $r = shift;
 		
-		if ($self->{routefilter}) {
+		if (!$self->{isolate} && $self->{routefilter}) {
 			$filter = undef;
 			if ($r) {
 				($filter, $hops) = $self->{routefilter}->it($self->{call}, $self->{dxcc}, $self->{itu}, $self->{cq}, $r->call, $r->dxcc, $r->itu, $r->cq);
@@ -1752,7 +1865,7 @@ sub send_route
 				dbg("was sent a null value") if isdbg('chanerr');
 			}
 		} else {
-			push @rin, $r;
+			push @rin, $r unless $self->{isolate} && $r->call ne $main::mycall;
 		}
 	}
 	if (@rin) {
@@ -1764,7 +1877,7 @@ sub send_route
 				$routeit = adjust_hops($self, $line);  # adjust its hop count by node name
 				next unless $routeit;
 			}
-			$self->send($routeit) if $self->{routefilter} || !$self->{isolate};
+			$self->send($routeit);
 		}
 	}
 }
@@ -1777,13 +1890,11 @@ sub broadcast_route
 	my $dxchan;
 	my $line;
 	
-	foreach $dxchan (@dxchan) {
-		next if $dxchan == $self;
-		next if $dxchan == $me;
-		if ($dxchan->{routefilter} || !$self->{isolate}) {
-			$dxchan->send_route($generate, @_) 
-		} else {
-			dbg('DXPROT: isolated') if isdbg('chanerr');
+	unless ($self->{isolate}) {
+		foreach $dxchan (@dxchan) {
+			next if $dxchan == $self;
+			next if $dxchan == $me;
+			$dxchan->send_route($generate, @_);
 		}
 	}
 }
@@ -1846,12 +1957,24 @@ sub in_filter_route
 sub eph_dup
 {
 	my $s = shift;
+	my $r;
 
 	# chop the end off
-	$s =~ s/\^H\d\d?\^?~?$//;
-	return 1 if exists $eph{$s};
+	$s =~ s/\^H\d\d?\^?\~?$//;
+	$r = 1 if exists $eph{$s};    # pump up the dup if it keeps circulating
 	$eph{$s} = $main::systime;
-	return undef;
+	return $r;
+}
+
+sub eph_del_regex
+{
+	my $regex = shift;
+	my ($key, $val);
+	while (($key, $val) = each %eph) {
+		if ($key =~ m{$regex}) {
+			delete $eph{$key};
+		}
+	}
 }
 
 sub eph_clean
@@ -1859,7 +1982,7 @@ sub eph_clean
 	my ($key, $val);
 	
 	while (($key, $val) = each %eph) {
-		if ($main::systime - $val > 90) {
+		if ($main::systime - $val > 180) {
 			delete $eph{$key};
 		}
 	}