use Script;
use strict;
+use warnings qw(all);
use vars qw($pc11_max_age $pc23_max_age $last_pc50 $eph_restime $eph_info_restime $eph_pc34_restime
$last_hour $last10 %eph %pings %rcmds $ann_to_talk
} else {
$user->homenode($homenode) if $homenode;
$user->node($homenode);
+ $user->priv(0);
}
$user->lastin($main::systime); # this make it last longer than just this invocation
$user->put; # just to make sure it gets written away!!!
# this is to fix a problem I introduced some build ago by using this function for users
# whereas it was only being used for nodes.
- if ($user->is_user && $user->lockout && $user->priv == 1) {
+ if ($user->is_user && $user->lockout && ($user->priv // 0) == 1) {
$user->priv(0);
$user->lockout(0);
dbg("DXProt: PC92 user record for $call depriv'd and unlocked");
my $is_extnode = $flag & 2;
my $here = $flag & 1;
my $ip;
- $part[1] //= 0;
- $part[2] //= 0;
- if ($part[1] =~ /[,.]/) {
- $ip = $part[1];
- $part[1] = $part[2] = 0;
- } elsif ($part[3] =~ /[,.]/) {
- $ip = $part[3];
+ my $version = $part[1] || 0;
+ my $build = $part[2] || 0;
+ $build =~ s/\D+//g;
+ my $ip = $part[3] || '';
+
+ if ($version =~ /[,.]/) {
+ $ip = $version;
+ $version = 0;
}
+ $version =~ s/\D+//g;
+ $build =~ s/^0\.//;
+ $build =~ s/\D+//g;
$ip =~ s/,/:/g if $ip;
- return ($call, $is_node, $is_extnode, $here, $part[1], $part[2], $ip);
+ return ($call, $is_node, $is_extnode, $here, $version, $build, $ip);
}
# decode a pc92 call: flag call : version : build
# remove spurious IPV6 prefix on IPV4 addresses
$ip =~ s/^::ffff:// if $ip;
-
+ $build ||= 0;
+ $version ||= 0;
+
if ($call) {
my $ncall = $parent->call;
if ($ncall ne $call) {
next if DXChannel::get($call);
$user = DXUser::get($call);
dbg("DXProt::_add_thingy call $call normalised to $normcall, deleting spurious user $call");
- $user->del;
+ $user->del if $user;
$call = $normcall; # this is safe because a route add will ignore duplicates
}
@rout = $parent->add($call, $version, Route::here($here), $ip);
$r = Route::Node::get($call);
$r->PC92C_dxchan($dxchan->call, $hops) if $r;
- if ($version && $version =~ /\d+/) {
+ if ($version && $version =~ /^\d+$/) {
my $old = $user->sort;
- if ($user->is_ak1a && (($version >= 5455 && defined $build && $build > 0) || ($version >= 3000 && $version <= 3500)) ) {
+ if ($user->is_ak1a && (($version >= 5455 && $build > 0) || ($version >= 3000 && $version <= 3500)) ) {
$user->sort('S');
- $build //= 0;
dbg("PCProt::_add_thingy node $call v: $version b: $build sort ($old) updated to " . $user->sort);
- } elsif ($user->is_spider && ($version < 3000 || ($version > 4000 && $version < 5455)) && $version =~ /^\d+$/) {
+ } elsif ($user->is_spider && $version =~ /^\d+$/ && ($version < 3000 || ($version > 4000 && $version < 5455))) {
unless ($version == 5000 && $build == 0) {
$user->sort('A');
$build //= 0;
}
$parent->here(Route::here($here));
$parent->version($version || $pc19_version) if $version;
- $build =~ s/^0\.//, $parent->build($build) if $build;
+ $parent->build($build) if $build;
$parent->PC92C_dxchan($self->{call}, $hops) unless $self->{call} eq $parent->call;
return ($parent, @radd);
}
push @radd, $add if $add;
$parent->reset_obs;
my $call = $parent->call;
- my $version = $ent[4] // 0;
- my $build = $ent[5] // 0;
- $build =~ s/^0\.//;
- my $oldbuild = $parent->build // 0;
- $oldbuild =~ s/^0\.//;
- my $oldversion = $parent->version // 0;
+ my $version = $ent[4] || 0;
+ my $build = $ent[5] || 0;
+ my $oldbuild = $parent->build || 0;
+ my $oldversion = $parent->version || 0;
my $user = check_add_user($parent->call, 'S');
- my $oldsort = $user->sort;
- if ($oldsort ne 'S' || $oldversion != $version || $build != $oldbuild) {
- dbg("PCProt PC92 K node $call updated version: $version (was $oldversion) build: $build (was $oldbuild) sort: 'S' (was $oldsort)");
- $user->sort('S');
- $user->version($parent->version($version));
- $user->build($parent->build($build));
- $user->put;
- }
-
+ my $oldsort = $user->sort // '';
+# if ($version =~ /^\d+$/ && $oldversion =~ /^\d+$/) {
+ if ($oldsort ne 'S' || $oldversion != $version || $build != $oldbuild) {
+ dbg("PCProt PC92 K node $call updated version: $version (was $oldversion) build: $build (was $oldbuild) sort: 'S' (was $oldsort)");
+ $user->sort('S');
+ $user->version($parent->version($version));
+ $user->build($parent->build($build));
+ $user->put;
+ }
+# } else {
+# dbg("DXProt PC92 K version strings new: '$version' old: '$oldversion'");
+# }
dbg("ROUTE: reset obscount on $parent->{call} now " . $parent->obscount) if isdbg('obscount');
}
} elsif ($sort eq 'A' || $sort eq 'D' || $sort eq 'C') {